Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity content and inline LG content should be displayed #2174

Closed
hibrenda opened this issue Mar 5, 2020 · 2 comments
Closed

activity content and inline LG content should be displayed #2174

hibrenda opened this issue Mar 5, 2020 · 2 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@hibrenda
Copy link
Contributor

hibrenda commented Mar 5, 2020

image

  • Activity content need to be fully displayed ( visual nodes)
  • Inline LG content need to be showed as expected (inline LG editor in form )
@hibrenda hibrenda added the Type: Bug Something isn't working label Mar 5, 2020
@hibrenda
Copy link
Contributor Author

hibrenda commented Mar 5, 2020

@mareekuh see attached image. For activity content, what should be displayed in visual editor?

most of the nodes have been updated to the new design but only SendActivity has no big change for "Activity" content and it has been rendered as above. Do you have any comments for this ? we should show all the content in visual or we have some trade off if you think this is too much. include @yeze322 as well to be aware of this issue.

# bfdactivity-775572
[Activity
    Text = ${Add-Todo-Text()}
    ${Welcome-Actions()}
]

@alanlong9278
Copy link
Contributor

alanlong9278 commented Mar 5, 2020

@hibrenda For activity can not be displayed in form editor, I find the reason. As the pic show, When opened the TodoWithLuis sample bot, activity.designer.id is not equal to activityId. in lg file, the content is bind to the activity id, but form editor lg content is filter by activity.designer.id. I think we should sync with @boydc2014 @luhan2017 Should we update the main.dialog or modify form editor filter condition.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants