Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lg template display wrong in visual & form editor #2191

Merged
merged 5 commits into from
Mar 6, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Mar 6, 2020

Description

fix lg template display wrong in visual & form editor

Bug Repro Steps:

  1. open TodoWithLuis sample
  2. click deleteItem trigger.

Bugs:

  1. Activity content be truncated in visual editor.
  2. Inline LG content is empty in form editor when selecting SendActivity card.

Reason:

  1. The activity content is the first line of lg template.
  2. The sample data is incorrect. Activity.designer.id is not equal to activityId. in lg file, the content is bind to the activity id, but form editor lg content is filter by activity.designer.id, So the inline LG content will be empty in form editor.

How to fix

  1. For activity content display in visual editor, there are two different way.
  • If lg template is normal string like
- hi
- hello

or
- ${List-readback(user.taskLists, dialog.listType)}
show all content.

  • If lg template is a text template like
[Activity
    Text = Ok, give me the exact title of the todo you would like to delete..
    SuggestedActions = Help | Cancel
]

show content behind Text =.
just like the pic show.
image

  1. For lg template is empty in form editor, just fix the id sync in toDoWithLuis sample.

Task Item

closes #2174

Screenshots

@github-actions
Copy link

github-actions bot commented Mar 6, 2020

Coverage Status

Coverage decreased (-0.04%) to 40.901% when pulling 45f619e on julong/activity into 964b8d6 on master.

@cwhitten cwhitten merged commit fed2515 into master Mar 6, 2020
@cwhitten cwhitten deleted the julong/activity branch March 6, 2020 15:13
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants