Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade lg parser and syntax #1676

Merged
merged 15 commits into from
Dec 4, 2019

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 2, 2019

Description

changes:

  1. upgrade to latest lg-parser, changes contains renaming and bug fix.
  2. use "botbuilder-lg" package-name instead of myget feed url in package dependency
  3. change lgParser API {Name, Parameters}.. upper case to lower case
  4. change sample bot lg syntax from [] to @{}
  5. Deprecated [template ] reference syntax will not be supported anymore

syntax updated:

  1. server/assets/projects/**/*.dialog
  2. server/assets/projects/**/*.lg
  3. lib/shared/lgUtils/{parsers,stringBuilders}
  4. lib/shared/dialogIndexer

Task Item

Closes #1676
Closes #1211
Closes #1542
Fixes #1680

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@zhixzhan zhixzhan changed the title refactor: upgrade to latest lg-parser refactor: upgrade lg parser and syntax Dec 3, 2019
@zhixzhan zhixzhan requested a review from luhan2017 as a code owner December 3, 2019 08:35
@yeze322
Copy link
Contributor

yeze322 commented Dec 3, 2019

I've checked those updates in '@bfc/shared -> lgUtils', no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants