fix: LU LSP suggest empty string entities and roles in entering utterance #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicshuai
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
compulim
reviewed
Jan 28, 2020
Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts
Outdated
Show resolved
Hide resolved
boydc2014
approved these changes
Feb 5, 2020
a-b-r-o-w-n
approved these changes
Feb 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a filter for remove the empty string entities and roles when calling suggestions in entering utterance.
For example, when user entered:
#Intent Name
LSP will generate the result of the entities user already defined.
Screenshots
Please include screenshots or gifs if your PR include UX changes.