-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update framework and package version in template botproject #1939
Conversation
I've tried this on my local environment, I find it strange, that this is still running on target framework netcoreapp2.1. Wouldn't it make sense, to update to netcoreapp2.2 ? EDIT: This resolves the issue, but I was getting build errors from a configured nuget source that failed. It's kind of annoying though, that the build errors can only be validated from running the build manually, and that composer wouldn't log the build errors to console. Makes reproducing and fixing a bit difficult. |
I applied the changes from this PR to my local version and I confirm that it fixes the 'Start Bot' issue. |
@VanyLaw Can we take this chance to upgrade to 3.1 if possible, 3.1 is a LTS version, and i hope that could save us efforts a lot of time. |
@VanyLaw, could you also update the sdk.schema in the template and Composer folder, and test whether the template bots work correctly? |
Some sample bots will throw "must be an expression" error. Seems like number need to be changed to expression after schema updated. According to @alanlong9278 , It will cause hige UI change. Maybe we need a discussion about it. |
* update the validation * fix some comments * update some logic
Description
Cause: The original version package reference was remove from repo, and caused sample bot project build failed.
Solution:
And @alanlong9278 will help to fix the UI to match schema change(number to expression).
FYI. those sdk main changes:
There is only one breaking change in the schema, others are all additions.
Task Item
fixes #1927
Screenshots