Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve known bugs in LU LSP. #2098

Merged
merged 7 commits into from
Feb 27, 2020
Merged

fix: resolve known bugs in LU LSP. #2098

merged 7 commits into from
Feb 27, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Feb 26, 2020 •
edited
Loading

closes #2046

  1. fix auto complete and indent in entering list entities
    fix auto complete in list

  2. fix auto complete and indent in entering utterances
    insert dash in utterance

  3. fix suggestions and autocomplete in entering phraseList
    phraseList suggestion and autocomplete

  4. insert whitespace after user pick a entity type
    insert whitespace

  5. other minor fixes, including:
    fix lu format doc link
    fix spellings of phraseList and Pattern.any

@cosmicshuai cosmicshuai merged commit 1112c86 into master Feb 27, 2020
@cosmicshuai cosmicshuai deleted the shuwan/fixLSPIssues branch February 27, 2020 05:36
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 9, 2020
Merged
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmicshuai @a-b-r-o-w-n