Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new action design to improve readability #2136

Merged
merged 44 commits into from
Mar 4, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Feb 28, 2020

Description

Implement new node design.
Design link: https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19-?node-id=4585%3A1049

1. New CardTemplate and uischema

image
uischema preview

const uischema = {
  [SDKTypes.SendActivity]: {
    'ui:widget': CardTemplate,
    header: {
      'ui:widget': ActionHeader,
      icon: ElementIcon.MessageBot,
      colors: {
        theme: ObiColors.BlueMagenta20,
        icon: ObiColors.BlueMagenta30,
      },
    },
    body: {
      'ui:widget': ActivityRenderer,
      field: 'activity',
    },
  }
};

2. New icon position:

image

3. Improve readability per $type

[See the 'screenshots' part for more details]
image

Task Item

closes #1701

Screenshots

  1. SendActivity
    image

  2. TextInput / NumberInput / DateInput / FileInput / Confirmation
    image

  3. ChoiceInput
    image
    image

  4. Dialog management
    image

  5. SetProperty / SetProperties
    image

  6. EditArray
    image

  7. DeleteProperty / DeleteProperties
    image
    image

  8. HttpRequest
    image

  9. EmitEvent
    image

  10. OauthInput
    image

  11. Debug options (LogAction, TraceActiivity)
    image

@yeze322 yeze322 changed the title feat: align to action design by implementing new node template feat: implement new action design to improve readability Mar 4, 2020
@yeze322 yeze322 marked this pull request as ready for review March 4, 2020 15:45
@cwhitten cwhitten merged commit 66986a2 into microsoft:master Mar 4, 2020
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants