-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new action design to improve readability #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc00c5c.
yeze322
changed the title
feat: align to action design by implementing new node template
feat: implement new action design to improve readability
Mar 4, 2020
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
March 4, 2020 15:45
cwhitten
approved these changes
Mar 4, 2020
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement new node design.
Design link: https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19-?node-id=4585%3A1049
1. New CardTemplate and uischema
uischema preview
2. New icon position:
3. Improve readability per $type
[See the 'screenshots' part for more details]
Task Item
closes #1701
Screenshots
SendActivity
TextInput / NumberInput / DateInput / FileInput / Confirmation
ChoiceInput
Dialog management
SetProperty / SetProperties
EditArray
DeleteProperty / DeleteProperties
HttpRequest
EmitEvent
OauthInput
Debug options (LogAction, TraceActiivity)