Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update HttpRequest sample #2161

Merged
merged 3 commits into from
Mar 6, 2020
Merged

fix: Update HttpRequest sample #2161

merged 3 commits into from
Mar 6, 2020

Conversation

luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented Mar 4, 2020

Description

Fix the http request body usage in the samples.

In the recently package update, http body type is changed from json which is evaluated by the obsolete ExpressionEvaluator to ValueExpression type which is now following the LG syntax.

So to make it work as expected, in the PR, I updated the way to refer to a property in http body from {property} to ${property}.

Task Item

fixes #2149

Screenshots

@luhan2017 luhan2017 changed the title Update HttpRequest sample fix: Update HttpRequest sample Mar 6, 2020
@github-actions
Copy link

github-actions bot commented Mar 6, 2020

Coverage Status

Coverage remained the same at 40.937% when pulling c04743a on luhan/updateHttpSample into 964b8d6 on master.

@cwhitten cwhitten merged commit 4da36a2 into master Mar 6, 2020
@cwhitten cwhitten deleted the luhan/updateHttpSample branch March 6, 2020 15:59
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants