-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi-locale bot file structure #2164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
March 4, 2020 10:42
…mposer into multiple-locale
Hi @cwhitten @boydc2014 @luhan2017 , after a lot of test fix, the multi-locale file structure changes is ready for review, please take a look when you guys have time. |
@zhixzhan can you please resolve conflicts? at that point we will review and prioritize merging this. |
OK, resolved. |
cwhitten
approved these changes
Mar 24, 2020
cwhitten
approved these changes
Mar 24, 2020
7 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* reform bot file structure * update * update * client add locale * crud with locale * update test sample bot * update * update emptybot structure * update crud test * auto fix lu referrence * reform sample bot structure * clean up * update dialogId & isBot * update * update test * redirect to root dialog * update * update test * update test entry * update tests * handle old bot * update sample * update refer * update * update * refer lg lu no locale * import lg no locale * update * fix refer * import resolve with locale * set test locale * get refered lu without locale * Temporary disable SendConversationUpdate in CSharp test case, for sdk locale issue * update test * update test * update test * update test * update * update test * use file resolver handle locale * test * resolve confilct * reform test samplebot * clean Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first stage of supporting multi-locale, reform the bot file structure.
change from current
to
And for one dialog, the folder abstract is
Task Item
refs #1922
refs #1726
close #2291
Screenshots