Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add luis authoring region for lubuild #2229

Merged
merged 1 commit into from
Mar 11, 2020
Merged

fix: add luis authoring region for lubuild #2229

merged 1 commit into from
Mar 11, 2020

Conversation

zidaneymar
Copy link
Contributor

@zidaneymar zidaneymar commented Mar 11, 2020 •
edited by luhan2017
Loading

Description

fixes #2218

  1. Create generated if not exists ( if user doesn't debug locally, the 'generated' folder would not be created and luis build would fail)
  2. Add luis authoring region in deploy.ps1.

Task Item

Screenshots

@zidaneymar zidaneymar changed the base branch from stable to master March 11, 2020 06:31
@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.713% when pulling 8757fa4 on qika/deployregion into bd5402b on master.

@zidaneymar zidaneymar merged commit ffc4d80 into master Mar 11, 2020
@zidaneymar zidaneymar deleted the qika/deployregion branch March 11, 2020 11:47
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authoring region not set in deploy.ps1 for lubuild command
2 participants
@zidaneymar @luhan2017