Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Use h1 tag for trigger in visual editor #2271

Merged
merged 4 commits into from
Mar 18, 2020
Merged

a11y: Use h1 tag for trigger in visual editor #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc229d0
replace h4 with h1
alanlong9278 Mar 16, 2020
8c6af1b
Merge branch 'master' into julong/headerTagInVisual
corinagum Mar 16, 2020
58b2793
Merge branch 'master' into julong/headerTagInVisual
cwhitten Mar 18, 2020
a86706d
Merge branch 'master' into julong/headerTagInVisual
cwhitten Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const Trigger = ({ data, onClick = () => {} }): JSX.Element => {
<div css={triggerContentStyle}>
<div css={titleStyle}>
<Icon iconName="Flow" style={triggerIconStyle} />
<h4 css={titleContentStyle}>{name}</h4>
<h1 css={titleContentStyle}>{name}</h1>
</div>
<div css={subtitleStyle} className="trigger__content-label">
{label}
Expand Down
1 change: 1 addition & 0 deletions Composer/packages/extensions/visual-designer/src/components/nodes/triggerStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const titleStyle: any = {
};

export const titleContentStyle = {
fontSize: '18px',
fontWeight: 600,
margin: '0px',
};
Expand Down