Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: '$type' -> '$kind' #2333

Merged
merged 13 commits into from
Mar 31, 2020
Merged

chore: '$type' -> '$kind' #2333

merged 13 commits into from
Mar 31, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Mar 23, 2020

⚠️ WARNING: BREAKING CHANGE

This will break existing bots that have $type written. To fix, update all occurrences of $type to $kind. But note that if the bot is on an older version of the runtime (early 4.7 release), the $kind property does not work.

Description

Converts all usage of $type to $kind.

Task Item

closes #2301

@yeze322
Copy link
Contributor Author

yeze322 commented Mar 23, 2020

UT failed because of '@bfc/shared' not updated

@a-b-r-o-w-n
Copy link
Contributor

@yeze322 thanks for opening this. As soon as I get the form work merged, I will tackle this.

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.04%) to 39.561% when pulling a1f4ce5 on schema/kind into 6407d7a on master.

@a-b-r-o-w-n a-b-r-o-w-n changed the title '$type' -> '$kind' chore: '$type' -> '$kind' Mar 31, 2020
@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review March 31, 2020 22:21
@cwhitten cwhitten merged commit dc8be58 into master Mar 31, 2020
@cwhitten cwhitten deleted the schema/kind branch March 31, 2020 22:48
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* refactor🦄(Visual Editor):'$type' to '$kind'

* update extension packages to use $kind

* update client to use $kind

* update server to use $kind

* update other packages to use $kind

* rename SDKTypes to SDKKinds

* update tests to use $kind

* update template bots to use $kind

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants