-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: '$type' -> '$kind' #2333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UT failed because of '@bfc/shared' not updated |
@yeze322 thanks for opening this. As soon as I get the form work merged, I will tackle this. |
a-b-r-o-w-n
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
March 31, 2020 22:21
cwhitten
approved these changes
Mar 31, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* refactor🦄(Visual Editor):'$type' to '$kind' * update extension packages to use $kind * update client to use $kind * update server to use $kind * update other packages to use $kind * rename SDKTypes to SDKKinds * update tests to use $kind * update template bots to use $kind Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will break existing bots that have
$type
written. To fix, update all occurrences of$type
to$kind
. But note that if the bot is on an older version of the runtime (early 4.7 release), the$kind
property does not work.Description
Converts all usage of
$type
to$kind
.Task Item
closes #2301