fix: lg parse template body/comments issue #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten and
yeze322
as code owners
|
Ready for review. Despite not all lgParser issue are fixed al, but resolved most common scenarios. |
a-b-r-o-w-n
requested changes
Apr 7, 2020
Composer/packages/tools/language-servers/language-generation/package.json
Show resolved
Hide resolved
Co-Authored-By: Andy Brown <asbrown002@gmail.com>
Co-Authored-By: Andy Brown <asbrown002@gmail.com>
…ackage.json Co-Authored-By: Andy Brown <asbrown002@gmail.com>
cwhitten
approved these changes
Apr 7, 2020
This was referenced Apr 7, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* upgrade lg package * update api methods * update api * upgrade package * upgrade package * update test * Update Composer/packages/client/package.json Co-Authored-By: Andy Brown <asbrown002@gmail.com> * Update Composer/packages/lib/indexers/package.json Co-Authored-By: Andy Brown <asbrown002@gmail.com> * Update Composer/packages/tools/language-servers/language-generation/package.json Co-Authored-By: Andy Brown <asbrown002@gmail.com> * Update package.json * Update package.json * Update package.json Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade lg parser including breaking api change, fix parse body
Task Item
close #2152
close #2374
refs #2398
Screenshots