chore: do not render extensions in iframe #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/a-b-r-o-w-n/BotFramework-Composer into chore/remove-extension-container
a-b-r-o-w-n
requested review from
boydc2014,
corinagum,
cwhitten and
yeze322
as code owners
|
@yeze322 could you review this one? |
|
@a-b-r-o-w-n I'm really excited on this change! After went through the code, I found 3 items for me to continue work on in Visual:
I will follow up these 3 items in separated PRs. |
|
I found several strange bugs related to dialog json editing |
cwhitten
approved these changes
Apr 6, 2020
This was referenced Apr 7, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* [wip] convert shell api from post message * hoist visual designer out of iframe * Fixed issues with Onboarding * Fixed issues with Onboarding * Fixed teaching bubble placement * remove copy css step * convert all usage of shell api to same frame implementation * remove extension container and related files * remove unused var * change FormEditor to PropertyEditor and fix e2e * show loading spinner when current dialog is not set * fix build errors * move test tsconfig into __tests__ directory * revert moving tsconfig to __tests__ * fix path substitution in client tests * remount the property editor when focus path changes * do not memoize shell data * remove route to serve extension container * fix vertical scroll on visual designer * reset current dialog when dialog id changes * use correct template ref syntax to get template name * fix lg references in todo sample Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: zeye <2295905420@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hoists extensions out of iframes and deprecates the messenger api client. Sets us up for passing JS plugins to extensions as well as improved performance.
Task Item
close #2121
refs #2371 - this may have addressed the performance issue I was seeing
refs #2120