Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot select nested actions in Visual Editor #2672

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Apr 16, 2020

Description

fix #2667 by putting svg before actions

A trick about DOM event capturing:

  • elements declared before <svg /> are unreachable
  • elements declared after <svg /> are reachable

image

Task Item

Screenshots

@yeze322 yeze322 changed the base branch from stable to master April 16, 2020 06:24
@yeze322
Copy link
Contributor Author

yeze322 commented Apr 16, 2020

To fix this problem thoroughly, need refinement on zindex order since we have a nested action flow.
image

@cwhitten cwhitten merged commit 9bf98c7 into microsoft:master Apr 16, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select certain action nodes
2 participants