Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: make focus visible on create node button #2677

Merged
merged 8 commits into from
Apr 17, 2020
Merged

a11y: make focus visible on create node button #2677

merged 8 commits into from
Apr 17, 2020

Conversation

alanlong9278
Copy link
Contributor

Description

As Marieke said:

Tab = black outline
Selection = blue outline
For the +, the outline should be around the circle, not a square.

Add circle outline for + button.
iconbutton-demo

Task Item

fix #2061

Screenshots

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.003%) to 41.945% when pulling 5b29669 on julong/addButtonUx into c186832 on master.

@a-b-r-o-w-n a-b-r-o-w-n changed the title ally: accessibility for 2061 a11y: accessibility for 2061 Apr 16, 2020
@a-b-r-o-w-n a-b-r-o-w-n changed the title a11y: accessibility for 2061 a11y: make focus visible on create node button Apr 16, 2020
corinagum
corinagum approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @alanlong9278!
@a-b-r-o-w-n could you dismiss your review and/or take a look?

@corinagum corinagum merged commit 836d0fe into master Apr 17, 2020
@corinagum corinagum deleted the julong/addButtonUx branch April 17, 2020 19:28
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@alanlong9278 @a-b-r-o-w-n @corinagum
a11y: make focus visible on create node button (microsoft#2677)
1d7ab56 
* add circle outline for add button

* add set menuSelected false callback

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees

@corinagum corinagum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanlong9278 @a-b-r-o-w-n @corinagum