-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: consolidate test-utils and add easy e2e script #2688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep this as a JS module to reduce compile steps, but at least consumers get type info
packages can include their own babel config instead
Closed
@a-b-r-o-w-n can you address conflicts? |
@cwhitten conflicts adressed! |
new conflicts :( |
cwhitten
approved these changes
Apr 20, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* rename e2e script to e2e-ci * [wip] start cross env e2e script * add assertion on visit page method * add @bfc/test-utils package * update visual designer to use test-utils * mark test-utils private * update adaptive-form to use test-utils * migrate extension to test-utils * migrate client to test-utils * update config function interfaces * add node configuration * update lockfile * migrate electron-server to test-utils * migrate lib to test-utils * migrate server to test-utils * migrate tools to test-utils * migrate ui-plugins to test-utils * update lock file * update documentation * add typings for test-utils Keep this as a JS module to reduce compile steps, but at least consumers get type info * convert all test imports to test-utils * allow configuration of babel options * convert missing js files to jsx * remove ability for babel overrides packages can include their own babel config instead * remove babel overrides from type * migrate ui-shared to test-utils * do not load other babel configs for tests * add e2e scripts to run app and clean artifacts in cross plat way * add more logging * add yarn script to start composer for e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates our jest config into
@bfc/test-utils
. This required changing a bunch of files from.js
to.jsx
.Also adds a script to start composer in a way that e2e tests can be run smoothly.
To start up, run
yarn test:integration:start-server
and thenyarn test:integration
oryarn test:integration:open
to run tests against the server.Task Item
closes #2613