Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consolidate test-utils and add easy e2e script #2688

Merged
merged 36 commits into from
Apr 20, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Consolidates our jest config into @bfc/test-utils. This required changing a bunch of files from .js to .jsx.

Also adds a script to start composer in a way that e2e tests can be run smoothly.

To start up, run yarn test:integration:start-server and then yarn test:integration or yarn test:integration:open to run tests against the server.

Task Item

closes #2613

@a-b-r-o-w-n a-b-r-o-w-n linked an issue Apr 16, 2020 that may be closed by this pull request
@cwhitten
Copy link
Member

@a-b-r-o-w-n can you address conflicts?

@a-b-r-o-w-n
Copy link
Contributor Author

@cwhitten conflicts adressed!

@cwhitten
Copy link
Member

new conflicts :(

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Apr 20, 2020
@cwhitten cwhitten merged commit 2936a71 into microsoft:master Apr 20, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* rename e2e script to e2e-ci

* [wip] start cross env e2e script

* add assertion on visit page method

* add @bfc/test-utils package

* update visual designer to use test-utils

* mark test-utils private

* update adaptive-form to use test-utils

* migrate extension to test-utils

* migrate client to test-utils

* update config function interfaces

* add node configuration

* update lockfile

* migrate electron-server to test-utils

* migrate lib to test-utils

* migrate server to test-utils

* migrate tools to test-utils

* migrate ui-plugins to test-utils

* update lock file

* update documentation

* add typings for test-utils

Keep this as a JS module to reduce compile steps, but at least consumers get type info

* convert all test imports to test-utils

* allow configuration of babel options

* convert missing js files to jsx

* remove ability for babel overrides

packages can include their own babel config instead

* remove babel overrides from type

* migrate ui-shared to test-utils

* do not load other babel configs for tests

* add e2e scripts to run app and clean artifacts in cross plat way

* add more logging

* add yarn script to start composer for e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] update cypress
2 participants