a11y: replace IconButton with Icon in responses table #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
beyackle
changed the title
|
Isn't this a dupe of #2639 ? |
|
After investigating this, it looks like a later change I made to table-view.tsx inadvertently returned that to being an IconButton (probably because of a careless merge conflict resolution) , so this fix repairs that.. |
|
LGTM! |
cwhitten
approved these changes
Apr 17, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor cleanup task to address a remaining ask from an issue with how the screen reader read rows of the Bot Responses table.
Task Item
closes #2049
Screenshots