Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: accessibility issue 2019 #2711

Merged
merged 4 commits into from
Apr 24, 2020
Merged

a11y: accessibility issue 2019 #2711

merged 4 commits into from
Apr 24, 2020

Conversation

liweitian
Copy link
Contributor

Description

add main landmark on each page

Task Item

Refs #2019

Screenshots

@cwhitten cwhitten assigned beyackle and unassigned corinagum Apr 20, 2020
beyackle
beyackle previously approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this - looks like role="main" is just what this needed.

@liweitian
Copy link
Contributor Author

Thanks for taking care of this - looks like role="main" is just what this needed.

solved code conflict.

@liweitian liweitian force-pushed the accessibility2019 branch 2 times, most recently from e434b16 to 0c3f942 Compare April 23, 2020 15:03
beyackle
beyackle reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, so clear up the merge conflicts and I'll approve the PR.

@liweitian
Copy link
Contributor Author

These look good, so clear up the merge conflicts and I'll approve the PR.

solved

@cwhitten cwhitten merged commit 3ff8732 into microsoft:master Apr 24, 2020
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@liweitian @cwhitten
a11y: accessibility issue 2019 (microsoft#2711)
9f7b08f 
* add main landmark on each page

* lint fix

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyackle beyackle beyackle approved these changes

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

Assignees

@beyackle beyackle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liweitian @cwhitten @beyackle @corinagum