Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add publish target configuration schema #2719

Merged
merged 12 commits into from
Apr 21, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Enables UX in the monaco editor when editing the publishing config.

Task Item

closes #2644

Copy link
Contributor

@benbrown benbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small typo otherwise 💯

Composer/packages/client/src/pages/publish/index.tsx Outdated Show resolved Hide resolved
- make settings type more restrictive
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 526e97f on a-b-r-o-w-n:feat/add-publish-schema into 2936a71 on microsoft:master.

@cwhitten cwhitten merged commit 630ba17 into microsoft:master Apr 21, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* extract plugin loader to own package

* move plugin loader to extension directory

* ignore mockRemotePlubish plugin lib dir

* add log method to composer plugin

* add dependency on plugin loader

* add schema to publish plugin config

* add better typing

* pass schema from publish plugin to create target

* apply schema defaults when loading json editor

* fix typo and build error

- make settings type more restrictive

* fix error handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants