-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add publish target configuration schema #2719
Merged
cwhitten
merged 12 commits into
microsoft:master
from
a-b-r-o-w-n:feat/add-publish-schema
Apr 21, 2020
Merged
feat: add publish target configuration schema #2719
cwhitten
merged 12 commits into
microsoft:master
from
a-b-r-o-w-n:feat/add-publish-schema
Apr 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
boydc2014,
corinagum and
cwhitten
as code owners
April 20, 2020 19:22
benbrown
requested changes
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small typo otherwise 💯
- make settings type more restrictive
cwhitten
approved these changes
Apr 21, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* extract plugin loader to own package * move plugin loader to extension directory * ignore mockRemotePlubish plugin lib dir * add log method to composer plugin * add dependency on plugin loader * add schema to publish plugin config * add better typing * pass schema from publish plugin to create target * apply schema defaults when loading json editor * fix typo and build error - make settings type more restrictive * fix error handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables UX in the monaco editor when editing the publishing config.
Task Item
closes #2644