-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented Auto-Update Electron UX #2721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mposer into toanzian/auto-update
tonyanziano
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
April 20, 2020 20:42
tonyanziano
changed the title
Implemented Auto-Update Electron UX
feat: Implemented Auto-Update Electron UX
Apr 20, 2020
a-b-r-o-w-n
reviewed
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about the complexity in the AppUpdater component. I don't have any specific suggestions though. I'll give this a functional whirl and leave another review.
cwhitten
approved these changes
Apr 21, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Started stubbing out auto updater. * Added logging. * Fixed build scripts. * Working rough draft of app update UX * More auto update UX polish. * More styling & visual polish. * Added client tests. * Added tests and more polish. * Fixed tests. * Linting fixes. * More linting fixes. * Addressing PR comments * Small settings tweak. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the UX for auto-updates in Composer Electron.
Task Item
closes #2226
Screenshots
Update available
Update available (dialog minimized)
Update failed
Update succeeded (user chose to install and restart)
Update succeeded (user chose to download the update manually)
Update unavailable
Update in progress (total size not yet known)
Update in progress
New electron-server tests for app updater
Client tests