Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented Auto-Update Electron UX #2721

Merged
merged 16 commits into from
Apr 21, 2020
Merged

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Apr 20, 2020

Description

This PR implements the UX for auto-updates in Composer Electron.

Task Item

closes #2226

Screenshots

Update available
update-available

Update available (dialog minimized)
update-available-minimized

Update failed
update-failed

Update succeeded (user chose to install and restart)
update-succeeded-1

Update succeeded (user chose to download the update manually)
update-succeeded-2

Update unavailable
update-unavailable

Update in progress (total size not yet known)
update-progress-1

Update in progress
update-progress-2

New electron-server tests for app updater
update-tests

Client tests
image

@tonyanziano tonyanziano changed the title Implemented Auto-Update Electron UX feat: Implemented Auto-Update Electron UX Apr 20, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 00de8d8 on toanzian/auto-update into c49d04c on master.

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the complexity in the AppUpdater component. I don't have any specific suggestions though. I'll give this a functional whirl and leave another review.

@cwhitten cwhitten merged commit c41d6ff into master Apr 21, 2020
@cwhitten cwhitten deleted the toanzian/auto-update branch April 21, 2020 19:15
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Started stubbing out auto updater.

* Added logging.

* Fixed build scripts.

* Working rough draft of app update UX

* More auto update UX polish.

* More styling & visual polish.

* Added client tests.

* Added tests and more polish.

* Fixed tests.

* Linting fixes.

* More linting fixes.

* Addressing PR comments

* Small settings tweak.

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants