Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: accessibility issue 2068 #2779

Merged
merged 5 commits into from
Apr 29, 2020
Merged

a11y: accessibility issue 2068 #2779

merged 5 commits into from
Apr 29, 2020

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Apr 26, 2020 •
edited by cwhitten
Loading

Description

I update the code to make the 'reloading' status easier to be read out before the status changed.
In most cases, the reloading status exists for a very short period. And while narrator announce 'reloading', it may also be interrupted by an error message. @ashish315 Can you help checking whether the current behavior acceptable?

I think the current process is like:

  1. Click start bot button, the narrator starts to read the status 'publishing' or 'reloading'
  2. Before the narrator finish, an error dialog may be pop up and get the focus. (We must focus on that dialog, otherwise we cannot click the try again or cancel button using keyboard)
  3. Since the focus changed, the narrator start to read something else.

Task Item

closes #2068

Screenshots

@cwhitten cwhitten requested a review from srinaath as a code owner April 27, 2020 20:24
cwhitten
cwhitten requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the unit tests is failing due to the markup change.

@cwhitten cwhitten merged commit 012f8ef into microsoft:master Apr 29, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling b654e8a on liweitian:accessibility2068-2 into 6ab67b2 on microsoft:master.

@cwhitten cwhitten mentioned this pull request Apr 29, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@liweitian @cwhitten
a11y: accessibility issue 2068 (microsoft#2779)
8197dfb 
* fix: narrator does not announce reloading

* fix test case

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten requested changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liweitian @cwhitten