feat: Added skill manifest editor wizard #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten and
srinaath
as code owners
a-b-r-o-w-n
requested changes
Apr 29, 2020
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/AdaptiveForm/index.tsx
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/AdaptiveForm/index.tsx
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/AdaptiveForm/index.tsx
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/exportSkillModal/content/SelectManifest.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/exportSkillModal/content/SelectManifest.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
requested changes
Apr 29, 2020
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Show resolved
Hide resolved
a-b-r-o-w-n
previously approved these changes
Apr 29, 2020
a-b-r-o-w-n
approved these changes
Apr 29, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* feat: Added skill manifest editor wizard * fixed lint issues * Updated schema uri * Revisions * Removed redundant suspense components * fixed lint issues * Updated spinner * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user clicks 'Export as skill' under the 'Export' toolbar menu, the skill manifest editor wizard renders in a modal. The user can create a new skill manifest by selecting which version of the manifest schema they want from the dropdown and then clicking the 'create' button. This will create a new file -
skill-manifest-${version}.manifest- in theskill-manifestsdirectory. If the user wants to edit an existing skill manifest instead, they can select the manifest they want to update from the list view.The next step uses the
AdaptiveFormpackage to allow the user to enter metadata for the skill manifest. After this step in the designs, the user should be able to select which triggers from the root dialog they want to include so the wizard can generate thedispatchModelsandactivitiesproperties; however, this is reliant on the user being able to create dialog schema files. Consequently, the generate manifest feature will be completed after the work pertaining to*.dialog.schemawork is completed. At the end of the editor experience, the user can see entire skill manifest in the JsonCode editor and make any necessary changes to the manifest.Task Item
Closes #2327
Screenshots