fix: add links to .NET Core SDK to publish error #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
benbrown
reviewed
May 12, 2020
| @@ -83,6 +83,7 @@ export const PublishController = { | |||
| // set status and return value as json | |||
| res.status(results.status).json(response); | |||
| } catch (err) { | |||
| console.error('Publishing error: ' + err.message); | |||
There was a problem hiding this comment.
this is not exactly what I meant, since this is just going to say
"failed to run dotnet build"
we can attach to the spawned child process and output the errors it generates to get more detail.
There was a problem hiding this comment.
the actual exec happens inside the localPublish plugin.
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add initial link stuff * add secondary link * adjust spacing and add console-error to server * make execSync pass stderror through * Update publisher.ts Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will detect if a publishing error relates to
dotnet, and if so will direct a user to the .NET Core SDK with a download link.Task Item
closes #2926
Screenshots