Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test coverage for adaptive-form #3371

Merged
merged 49 commits into from
Jun 10, 2020
Merged

test: add unit test coverage for adaptive-form #3371

merged 49 commits into from
Jun 10, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

#minor

@a-b-r-o-w-n
ignore default schemas
f90edde
@a-b-r-o-w-n
remove unused code
2869787
@a-b-r-o-w-n
add test for plugin config hook
022850f
@a-b-r-o-w-n
refactor test-utils exports
b4949c5 
* convert to typescript project
* export react test utils from lib/react
* export hooks test utils from lib/hooks
@a-b-r-o-w-n
add test coverage for utils
0882364
@a-b-r-o-w-n
do not throw error if all fields are ordered
eed6327
@a-b-r-o-w-n
fix outdated types for react testing library
c3fb81b
@a-b-r-o-w-n
add unit test for error message
5fc35e3
@a-b-r-o-w-n
add unit tests for field label
b9c5625
@a-b-r-o-w-n
ignore link in coverage
c046f5a
@a-b-r-o-w-n
add unit test for FormRow
7b0a978
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
7b26413
@a-b-r-o-w-n
add unit tests for schema field
e3dfcc2
@a-b-r-o-w-n
add unit tests for ObjectItem
2127b0a
@a-b-r-o-w-n
add snippet for react component test scaffold
46fecc7
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
264929c
@a-b-r-o-w-n
add OpenObjectField unit tests
716b32d
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
551efdd
@a-b-r-o-w-n
revert not exporting react test utils
ebd13f2
@a-b-r-o-w-n
add unit tests for OneOfField
9b5c244
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
b53ff70
@a-b-r-o-w-n
add unit tests for StringField
5c3f2ef
@a-b-r-o-w-n
add unit tests for UnsupportedField
7c9e702
@a-b-r-o-w-n
add unit tests for BooleanField
7661d42
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
e7c3a5f
@a-b-r-o-w-n
remove coverage ignore statement
dfe1e22
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
a55efb2
@a-b-r-o-w-n
allow non-null assertion in test
9a80ce3
@a-b-r-o-w-n
add unit test for NumberField
8c5bdc5
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
6b63372
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
3f89b27
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
73cefc0
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
fb90d45
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
3f02846
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
631793c
@a-b-r-o-w-n
add unit test for SelectField
10948a4
@a-b-r-o-w-n
add unit tests for ArrayField
c409163
@a-b-r-o-w-n
add unit test for ArrayFieldItem
a577ff1
@a-b-r-o-w-n
render string field with a transparent border
dd08313
@a-b-r-o-w-n
add unit test for IntentField
455b6fc 
remove recognizerType function, use isSelected instead
@a-b-r-o-w-n
add unit test for JsonField
5da1447
@a-b-r-o-w-n
do not include wildcard in ordered properties
c246fdd
@a-b-r-o-w-n
add unit test for ObjectArrayField
dbab429
@a-b-r-o-w-n
add unit test for ObjectField
dc26807
@a-b-r-o-w-n
add unit test for RecognizerField
9c910d4
@a-b-r-o-w-n
Merge branch 'master' into abrown/test/adaptive-form
ef0ad97
@a-b-r-o-w-n
add unit test for RegexIntentField
0144f7f
@a-b-r-o-w-n
fix linting error
9fe613a
@coveralls
Copy link

Coverage Status

Coverage increased (+4.7%) to 47.707% when pulling d905ff7 on abrown/test/adaptive-form into 50bfc96 on master.

@cwhitten cwhitten merged commit b37a88b into master Jun 10, 2020
@cwhitten cwhitten deleted the abrown/test/adaptive-form branch June 10, 2020 23:22
@cwhitten cwhitten mentioned this pull request Jul 8, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
test: add unit test coverage for adaptive-form (microsoft#3371)
35c2d3d 
* ignore default schemas

* remove unused code

* add test for plugin config hook

* refactor test-utils exports

* convert to typescript project
* export react test utils from lib/react
* export hooks test utils from lib/hooks

* add test coverage for utils

* do not throw error if all fields are ordered

* fix outdated types for react testing library

* add unit test for error message

* add unit tests for field label

* ignore link in coverage

* add unit test for FormRow

* add unit tests for schema field

* add unit tests for ObjectItem

* add snippet for react component test scaffold

* add OpenObjectField unit tests

* revert not exporting react test utils

* add unit tests for OneOfField

* add unit tests for StringField

* add unit tests for UnsupportedField

* add unit tests for BooleanField

* remove coverage ignore statement

* allow non-null assertion in test

* add unit test for NumberField

* add unit test for SelectField

* add unit tests for ArrayField

* add unit test for ArrayFieldItem

* render string field with a transparent border

* add unit test for IntentField

remove recognizerType function, use isSelected instead

* add unit test for JsonField

* do not include wildcard in ordered properties

* add unit test for ObjectArrayField

* add unit test for ObjectField

* add unit test for RecognizerField

* add unit test for RegexIntentField

* fix linting error

* update hooks imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @coveralls @cwhitten