Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endpoint, authoringEndpoint missing after publishing luis #3396

Merged
merged 5 commits into from
Jun 16, 2020

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Jun 12, 2020

Description

Fix endpoint, authoringEndpoint missing after publishing luis

Task Item

close #3395

Screenshots

AnyConv com__2020-06-12_152840

@coveralls
Copy link

coveralls commented Jun 12, 2020

Coverage Status

Coverage increased (+0.3%) to 48.046% when pulling 1967433 on wenyluo/fix3395 into bac3e28 on master.

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests for this.

state,
actions
);
expect(getByText('What is the name of your bot?')).not.toBeNull();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(getByText('What is the name of your bot?')).not.toBeNull();
expect(getByText('What is the name of your bot?')).toBeInTheDocument();

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Jun 16, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit 1fc4527 into master Jun 16, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the wenyluo/fix3395 branch June 16, 2020 19:35
@cwhitten cwhitten mentioned this pull request Jul 8, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…soft#3396)

* fix endpoint missing bug

* add unit test

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

endpoint and authoringEndpoint will be removed after luis publish
3 participants