Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix profile not saving #3556

Closed
wants to merge 1 commit into from
Closed

fix: fix profile not saving #3556

wants to merge 1 commit into from

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Jul 3, 2020

Description

Fix profile saving and editing issue in publish page.

Task Item

refs #3550 #3525

Screenshots

AnyConv com__Video_2020-07-03_171753

@VanyLaw VanyLaw changed the title fix profile edit and save not saving to settings fix: fix profile not saving Jul 3, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 53.244% when pulling 218eedb on wenyluo/fixProfileSave into 9bd3ecd on master.

@boydc2014
Copy link
Contributor

@VanyLaw can you state more about the root cause here? I thought #3550 fixed the adding publish profile page failed to render, is this PR fixing something #3550 was missing, or a new regression after we take #3550 ?

@boydc2014
Copy link
Contributor

OK, i get it, If i understand correctly, #3550 only fix the page is not rendering issue, but after 3550, the profile is not actually serialized to disk, which is fixed in this PR, right?

@boydc2014
Copy link
Contributor

This one looks good and works for me, but as we can see, we have several issues related to publishing, just between the time windows of 1.0.1 to 1.0.2. @VanyLaw how can we improve and guarantee the overall quality of this part? Please re-think about this and create a plan for this.

@boydc2014
Copy link
Contributor

Close this dup to #3556 have merged this.

@boydc2014 boydc2014 closed this Jul 3, 2020
@VanyLaw
Copy link
Contributor Author

VanyLaw commented Jul 3, 2020

OK, i get it, If i understand correctly, #3550 only fix the page is not rendering issue, but after 3550, the profile is not actually serialized to disk, which is fixed in this PR, right?

Yes, #3550 fix the render broken issue, but not exactly save it to settings file. And I will add more unit test and e2e test about the settings and deploy stuff later.

@cwhitten cwhitten deleted the wenyluo/fixProfileSave branch July 10, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants