Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing browser autocomplete on Intellisense fields #4129

Merged
merged 10 commits into from
Sep 17, 2020
Merged

fix: Removing browser autocomplete on Intellisense fields #4129

merged 10 commits into from
Sep 17, 2020

Conversation

LouisEugeneMSFT
Copy link
Contributor

@LouisEugeneMSFT LouisEugeneMSFT commented Sep 14, 2020 •
edited
Loading

Task Item

closes #4127

@LouisEugeneMSFT LouisEugeneMSFT linked an issue Sep 14, 2020 that may be closed by this pull request
Browser autocomplete conflicts with Intellisense #4127
Closed
@LouisEugeneMSFT LouisEugeneMSFT changed the title fix: Issue 4127 closes 4127 fix: Removing browser autocomplete on Intellisense fields Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 15, 2020
boydc2014
boydc2014 previously approved these changes Sep 15, 2020
View reviewed changes
@boydc2014
Copy link
Contributor

Please fix the lint error, i think it's related to the import order. Run yarn lint -fix should be able to auto-fix it.

@a-b-r-o-w-n a-b-r-o-w-n removed the Approved to merge approved, waiting to be merged label Sep 15, 2020
@a-b-r-o-w-n a-b-r-o-w-n self-requested a review September 15, 2020 15:20
a-b-r-o-w-n
a-b-r-o-w-n previously requested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a lint error.

@coveralls
Copy link

coveralls commented Sep 15, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.285% when pulling 21375a0 on leugene/issue4127 into ee4633a on main.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 16, 2020
@cwhitten cwhitten merged commit 5f3d153 into main Sep 17, 2020
@cwhitten cwhitten deleted the leugene/issue4127 branch September 17, 2020 00:35
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@LouisEugeneMSFT @a-b-r-o-w-n
@GeoffCoxMSFT @cwhitten
fix: Removing browser autocomplete on Intellisense fields (microsoft#…
2159f8b 
…4129)

* stringifying object examples

* fix

* unmerging prs

* lint

Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffCoxMSFT GeoffCoxMSFT GeoffCoxMSFT approved these changes

@boydc2014 boydc2014 boydc2014 left review comments

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser autocomplete conflicts with Intellisense
6 participants
@LouisEugeneMSFT @boydc2014 @coveralls @a-b-r-o-w-n @GeoffCoxMSFT @cwhitten