Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qna migration bug #4169

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Sep 17, 2020

Description

We should do migration on server. This pr will check missing qna files, create them and return all files to client.

Task Item

Closes #4168

Screenshots

@coveralls
Copy link

coveralls commented Sep 17, 2020

Coverage Status

Coverage increased (+0.2%) to 55.415% when pulling b9c0189 on liweitian:fixQnAFileMigration into 34b7aa6 on microsoft:main.

@srinaath srinaath self-assigned this Sep 17, 2020
srinaath
srinaath previously approved these changes Sep 18, 2020
@liweitian liweitian merged commit 3c60d8a into microsoft:main Sep 18, 2020
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix qna migration bug

* fix unit test

* handle comments

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qna files migration errors.
4 participants