fix: provision issue for QnA, split QnA template #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zidaneymar
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
luhan2017
approved these changes
Sep 22, 2020
a-b-r-o-w-n
approved these changes
Sep 23, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 28, 2020
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: update l10n file (#4247) fix: fix loading of extensions by removing sample-ui-plugin (#4251) fix: split qna resource to another template (#4212) feat: UI Schema - Recognizer (#4135) fix: Change http to https for petstore.swagger.io calls (#4238) feat: install remote extensions from npm (#4224) fix: refactored select skill ui-plugin (#4207) feat: Added fieldSets to UIOptions (#4231) fix: New LG template not sync to other locale files (#4230)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: Azure/azure-sdk-for-js#10186
QnA template doesn't support 'condition' variable which could control whether to deploy qna or not, so split the template file to two parts: qna resource and other resources
If createQnAResouce is true, deploy qna resource based on the independent qna template and other resources with the original template
if createQnAResource is false, deploy the other resources based on the original template
Task Item
Closes #4114
If we add api-version, the arm template would pop up another error message indicates the issue Azure/azure-sdk-for-js#10186
Screenshots