fix: Fix resizing problems by replacing resizable with splitter controls #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
hatpick
suggested changes
Sep 25, 2020
Composer/packages/client/src/components/ProjectTree/ProjectTree.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/ProjectTree.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Split/LeftRightSplit.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Split/LeftRightSplit.tsx
Outdated
Show resolved
Hide resolved
hatpick
previously approved these changes
Sep 25, 2020
cwhitten
reviewed
Sep 28, 2020
cwhitten
approved these changes
Sep 28, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ols (microsoft#4278) * Trying out the splitter * Improve layout * Updates and improvements * Moving to internal code for splitter * Move to emotion for splitter * Added top-bot splitter * Set min-max on splitter * Update min-max to numbers * Update min-max to numbers * Update NavTree.tsx * Update ProjectTree.tsx * PR fixes * PR fix Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces using resizable with a splitter control. Resizable is attached to a child control which causes resizing problems because it is not aware of the full area being split and does not property react to window sizes. It also requires controls participating in a split to be aware of resizeable rather than being contained in a layout container control.
Verified both on web and within electron application.
Task Item
Closes #4220
Fixes #3710
Screenshots