fix: Action flyout menu only shows defined $kinds in sdk.schema #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
Sep 30, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…osoft#4284) * filter $kinds not in sdk.schema from menu config * update comment * use forEach instead of reduce * fix UT Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4107
Problem: If a $kind is defined in uischema but not defined in sdk.schema, it will still be shown in the Action flyout menu.
Solution: This PR fixes that problem by filtering those $kinds not exist in sdk.schema, only when a $kind is defined correctly in both sdk.schema and uischema will it appear as a flyout option.
To validate this PR, try removing a $kind's definition in sdk.schema, you will find that the removed Action is also removed from Action flyout menu.
Task Item
#4107
Screenshots