Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for nested fieldsets #4364

Merged
merged 2 commits into from
Oct 14, 2020
Merged

feat: Added support for nested fieldsets #4364

merged 2 commits into from
Oct 14, 2020

Conversation

tdurnford
Copy link
Collaborator

Description

This updates the UI Options to support nested fieldsets. If a fieldset contains another fieldset object, the <PivotFieldsets /> component renders the top level fieldsets and the <Fieldsets /> component will render the secondary fieldsets in <CollapsableField /> components.

Note, if a fieldsets contains a fieldset object as a field, then all of the fields in that fieldset must also be fieldset objects; otherwise, all of the fields must be strings representing property names. Also fieldsets deeper than two levels are not supported.

{
  fieldsets: [
    {
      title: 'set 1',
      fields: [
        { title: 'set 1a', fields: ['one', 'two'] },
        { title: 'set 1b', fields: ['*'] }
       ]
     },
     {
       title: "set 2",
       fields: ['tree', 'four', 'five]
     }
  ]
}

Task Item

Closes #4363

Screenshots

a69b34af-e89b-4672-bf82-dd15cd7c25d7

@cwhitten
Copy link
Member

What is failing CI is unrelated to this change. I'll override to keep progress moving forward.

@cwhitten cwhitten merged commit 68cb8bb into microsoft:main Oct 14, 2020
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
@tdurnford tdurnford deleted the feature/nested-fieldsets branch November 30, 2020 21:44
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[property-editor] Add support for nested fieldsets
3 participants