-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add self contained config in dotnet publish #4391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an param for deployment, and default it to windows? Later if customer want to have a customized deployment (for example, linux vm), they can just set the param in the script.
OK, I will add it today. |
37db2b8
to
1b871cc
Compare
@zidaneymar @luhan2017 I'd like to verify that this won't break existing publishing profiles without this new shape, and allow users with old publishing profiles to add this new parameter. |
Tested 4 different scenarios: |
@zxyanliu, this may need a doc update, users needs to understand what this field means and how to use it. |
No problem, let's discuss in detail offline. |
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Description
Under linux environment, webapp bot couldn't be started up after dotnet publishing.
This issue only occurs at 'linux' env.
For runtime identifier: please refer to this doc: https://docs.microsoft.com/en-us/dotnet/core/rid-catalog
Task Item
fixes #4348
Screenshots