fix: Move bf-generate-lib templates to asar.unpacked #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
srinaath and
tonyanziano
as code owners
GeoffCoxMSFT
requested changes
Oct 16, 2020
GeoffCoxMSFT
previously approved these changes
Oct 16, 2020
…oser into sorgh/4410_4381
GeoffCoxMSFT
approved these changes
Oct 17, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* decompose shell and api into smaller types * nest plugin pages under bot scope * simplify webpack config * make extension client external * add mechanism to sync client shell to iframe plugin host * only fetch extensions when app mounts * add plugin pages selector * output source maps with extension bundles * rename file * clean up manifest after loading extensions * add project api hook * update sample plugin to use project api * disable sample-ui-plugin * do not sync store to window * prepare test-utils and types for publishing * update package references to published pacakges * add types package * remove shared dependency from extension-client * remove data from shell * more types updates * add useFormHook to expose current form data * re-order useEffects * add missing import * move types to dependencies * fix type errors * add missing dependency * fix tests * remove old comments * update lockfile * use stub currentDialog when none found * fix build:dev * fix merge conflict * form dialog templates electron asar unpacked * Move templates to unpacked * Update hint texts and minor fixes Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves bf-generate-lib templates to asar.unpacked
Adds missing hint texts to form dialog UX
Updates bf-generate-lib to the latest version
Minor fixes
Task Item
fixes #4410
closes #4381