feat: Bot Project Schema Update #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/.gitignore
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-schema
…rosoft/BotFramework-Composer into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
tonyanziano
as code owners
hatpick
reviewed
Oct 20, 2020
| @@ -1,12 +1,13 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT License. | |||
|
|
|||
| import path from 'path'; | |||
There was a problem hiding this comment.
You sure you can use this module on the browser?
cwhitten
approved these changes
Oct 21, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added schema for bot project support Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Add 1.0 botproject schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix typo Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated gitignore Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Typo fixed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Following sdk.schema approach to specificy object type using ref Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed workspace references. Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Relative path support Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update operations on Bot project file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated tests for removing workspace reference Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed manifest update operation Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Cleared logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes workspace reference in Bot Project file. This file would always be nested directly inside the Root Bot. All skills added would be referred using a relative path from the root bot. A typo was made with the version of BotProject file. Changing it to 0.2.0 and will be upgraded to 1.0.0 at the end of R11.
Fixes #4162