Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify create qna from url/scratch window height #4432

Merged
merged 9 commits into from
Oct 22, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Oct 20, 2020

Description

UX required change: unify create qna from url/scratch window same size (W 600px , H 500 px).

Task Item

#minor

Screenshots

image

image

@coveralls
Copy link

coveralls commented Oct 20, 2020

Coverage Status

Coverage remained the same at 55.339% when pulling c021cce on zhixzhan/create-qna into 31819e7 on main.

boydc2014
boydc2014 previously approved these changes Oct 20, 2020
@boydc2014 boydc2014 added Team: Authoring Approved to merge approved, waiting to be merged labels Oct 20, 2020
@cwhitten cwhitten merged commit fcea344 into main Oct 22, 2020
@cwhitten cwhitten deleted the zhixzhan/create-qna branch October 22, 2020 16:19
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* unify create qna from url/scratch
window height

* update to wh to 600 x 500

* lint

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged Team: Authoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants