Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error message in QnA KB creation #4497

Merged
merged 5 commits into from
Oct 23, 2020
Merged

fix: error message in QnA KB creation #4497

merged 5 commits into from
Oct 23, 2020

Conversation

zxyanliu
Copy link
Contributor

@zxyanliu zxyanliu commented Oct 23, 2020 •
edited
Loading

Description

Before

image
image

Task Item

#4448
#minor

Screenshots

After

qna-1

beyackle
beyackle suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should have the yarn l10n script run and the resulting changes to en-US.json committed alongside it.

@zxyanliu
Copy link
Contributor Author

beyackle
This PR should have the yarn l10n script run and the resulting changes to en-US.json committed alongside it.

That's a great point, Ben! Thanks for bringing it up!
I will update it.

@coveralls
Copy link

coveralls commented Oct 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.297% when pulling 7860243 on zxyanliu/errorMessage/20201022 into 032f17a on main.

@zxyanliu zxyanliu changed the title fix: Error message in QnA KB creation fix: error message in QnA KB creation Oct 23, 2020
@zxyanliu
Copy link
Contributor Author

zxyanliu commented Oct 23, 2020 •
edited
Loading

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

@zxyanliu zxyanliu linked an issue Oct 23, 2020 that may be closed by this pull request
Suggested refinement of the validation error messages #4448
Closed
@zxyanliu zxyanliu requested a review from beyackle October 23, 2020 19:07
@beyackle
Copy link
Contributor

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

That's the result of other earlier changes that didn't run the script. I'm okay with merging these just so the file stays up-to-date without needing another PR just to take care of those.

@zxyanliu
Copy link
Contributor Author

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

That's the result of other earlier changes that didn't run the script. I'm okay with merging these just so the file stays up-to-date without needing another PR just to take care of those.

Thank you! That makes sense to me.

@beyackle beyackle merged commit e828b62 into main Oct 23, 2020
@beyackle beyackle deleted the zxyanliu/errorMessage/20201022 branch October 23, 2020 19:35
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zxyanliu @beyackle
fix: error message in QnA KB creation (microsoft#4497)
912d586 
* Update constants.ts

* run scripts and bring changes to the en-us file.

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyackle beyackle beyackle approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested refinement of the validation error messages
3 participants
@zxyanliu @coveralls @beyackle