Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extensions to read/write data #4499

Merged
merged 8 commits into from
Oct 26, 2020
Merged

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Adds ability for extensions to access their own store to read/write arbitrary data and persist across updates / reloads.

Task Item

closes #4004

@a-b-r-o-w-n
Copy link
Contributor Author

I have tested the electron distro locally, including starting a bot.

@coveralls
Copy link

coveralls commented Oct 23, 2020

Coverage Status

Coverage decreased (-0.005%) to 55.041% when pulling 26c37ff on abrown/extension-data into c48021e on main.

benbrown
benbrown previously approved these changes Oct 26, 2020
@benbrown benbrown merged commit 67bc817 into main Oct 26, 2020
@benbrown benbrown deleted the abrown/extension-data branch October 26, 2020 17:49
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* extract store base class

* rename env variable

* add COMPOSER_EXTENSION_DATA_DIR env variable

* allow extensions to read/write data

* refactor store api

* fix error when when path is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions should be able to read/write data to their own database
4 participants