Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mismatched schema in custom action example #4510

Merged
merged 7 commits into from
Oct 27, 2020
Merged

fix: mismatched schema in custom action example #4510

merged 7 commits into from
Oct 27, 2020

Conversation

zxyanliu
Copy link
Contributor

@zxyanliu zxyanliu commented Oct 23, 2020 •
edited
Loading

@zxyanliu zxyanliu requested a review from luhan2017 October 23, 2020 20:30
@zxyanliu
Copy link
Contributor Author

To make it consistent with updates to the doc, I updated the schema in the sample as well. cc: @luhan2017

@zxyanliu zxyanliu linked an issue Oct 23, 2020 that may be closed by this pull request
Custom Runtime Error #4416
Closed
8 tasks
@coveralls
Copy link

coveralls commented Oct 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.028% when pulling 1483d4e on zxyanliu/fixExampleSchema into 8adbc16 on main.

@boydc2014 boydc2014 merged commit 4d113c8 into main Oct 27, 2020
@boydc2014 boydc2014 deleted the zxyanliu/fixExampleSchema branch October 27, 2020 04:24
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zxyanliu @luhan2017
@boydc2014 @cwhitten
Update MultiplyDialog.schema (microsoft#4510)
5b49c7d 
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Runtime Error
5 participants
@zxyanliu @coveralls @luhan2017 @boydc2014 @cwhitten