fix: Action title not displayed #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
reviewed
Oct 26, 2020
boydc2014
previously approved these changes
Oct 26, 2020
a-b-r-o-w-n
reviewed
Oct 26, 2020
hatpick
reviewed
Oct 26, 2020
cwhitten
approved these changes
Oct 27, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* handle functional `label` value * conditional set fn title * title fn be aware of data context * update the type declaration * fix the wrong tab title * make sdkSchema optional * fix ActionCard UT * only process title instead of whole schema Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#minor
Problem
Title of an Action node can be empty when Form plugin overrides the schema title with a function.
Fixes
labelis a function.aria-labelissue which is not reported yet.Task Item
Screenshots