Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude no template definition warning in LG editor #4525

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Oct 26, 2020

#minor
In this PR, LG editor will ignore warning of parsing an empty LG file. It will no longer show the error message:
LG file must have at least one template definition.

Empty LG file will not show error:
no_error

Other LG error will still appear in the editor:
error

@cosmicshuai cosmicshuai changed the title minor: Exclude no template definition warning in LG editor fix: Exclude no template definition warning in LG editor Oct 26, 2020
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Oct 26, 2020
@coveralls
Copy link

coveralls commented Oct 26, 2020

Coverage Status

Coverage increased (+0.002%) to 55.046% when pulling 23e6956 on shuwan/removeLGEmptyFileWarn into 006a589 on main.

@cwhitten cwhitten merged commit a075963 into main Oct 26, 2020
@cwhitten cwhitten deleted the shuwan/removeLGEmptyFileWarn branch October 26, 2020 15:34
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants