fix: Improving the ui for when "additionalProperties": true #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisEugeneMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
tdurnford
reviewed
Oct 26, 2020
Composer/packages/adaptive-form/src/components/fields/OneOfField/utils.ts
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Oct 26, 2020
Composer/packages/adaptive-form/src/components/fields/OpenObjectField/ObjectItem.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Oct 26, 2020
Co-authored-by: TJ Durnford <tjdford@gmail.com>
tdurnford
approved these changes
Oct 26, 2020
tdurnford
approved these changes
Oct 27, 2020
GeoffCoxMSFT
approved these changes
Oct 27, 2020
GeoffCoxMSFT
approved these changes
Oct 27, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#4536) * Improving the ui for when "additionalProperties": true * Apply suggestions from code review Co-authored-by: TJ Durnford <tjdford@gmail.com> * PR comment * Making sure styling is consistent Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new adaptive forms UI doesn't adapt well to objects with "additionalProperties": true: the gray box with icon shouldn't be there in nested ui. This is the case for the Microsoft.HttpRequest body's property for example.
This PR addresses this issue (see screenshots of before and after).
Task Item
closes #4535
Screenshots
Before (See body property):
Before (When adding key value pairs):
After:
