fix: Calls form dialog dedicated delete api when dialog is removed #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
srinaath and
tonyanziano
as code owners
| } | ||
|
|
||
| const response = await httpClient.delete(`/formDialogs/${projectId}/${dialogId}`); | ||
| await reloadProject(callbackHelpers, response); |
There was a problem hiding this comment.
Do we need to do anything with the file state to prevent the delete from causing that issue with reloading (that thing you previously saw during generation)?
GeoffCoxMSFT
approved these changes
Oct 28, 2020
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Oct 29, 2020
* Update en-US.json * bring in stuff from the draft branch * make deletion work * add error/warning icons * read notification map for state * fix type-checking and start on unit tests * add sampleDialog and fix more tests * add showAll * rename to onAllSelected because it's a callback * update unit tests * fix onSelect handling in ProjectTree * Update qna.test.tsx * Update design.test.tsx * add unit test * fixes from PR comments * restore multibots to tree * fix links from project tree * fix wrong IDs in URL * yarn.lock rebuild * update yarn.lock files * fix action card links * Update DesignPage.tsx * fix unit test * add unit test to ExpandableNode * update ProjectTree unit tests * Update ExpandableNode.tsx * add rootProjectId to triggerApi * fix creation and deletion bugs * change mocks folder name * Load design page only after skill project is loaded Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * fixes from CR * fix more tests * fix: handle the case when selection is not empty (microsoft#4561) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * delete fd (microsoft#4556) Co-authored-by: Soroush <sorgh@microsoft.com> * fix more unit tests * revert: bf-orchestrator lib integration (microsoft#4568) This reverts commit 006a589. Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix test typol * ci: remove code scanning workflow (microsoft#4569) * fix: Can not add properties in "SetProperties" action (microsoft#4572) * bug fix * pr comment * pr comments Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
lei9444
added a commit
that referenced
this pull request
Nov 11, 2020
* feat: Notifications Page * update the unit tests * fix merge conflict * update the name * fix unit test * Test skill (#2) * Update en-US.json * bring in stuff from the draft branch * make deletion work * add error/warning icons * read notification map for state * fix type-checking and start on unit tests * add sampleDialog and fix more tests * add showAll * rename to onAllSelected because it's a callback * update unit tests * fix onSelect handling in ProjectTree * Update qna.test.tsx * Update design.test.tsx * add unit test * fixes from PR comments * restore multibots to tree * fix links from project tree * fix wrong IDs in URL * yarn.lock rebuild * update yarn.lock files * fix action card links * Update DesignPage.tsx * fix unit test * add unit test to ExpandableNode * update ProjectTree unit tests * Update ExpandableNode.tsx * add rootProjectId to triggerApi * fix creation and deletion bugs * change mocks folder name * Load design page only after skill project is loaded Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * fixes from CR * fix more tests * fix: handle the case when selection is not empty (#4561) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * delete fd (#4556) Co-authored-by: Soroush <sorgh@microsoft.com> * fix more unit tests * revert: bf-orchestrator lib integration (#4568) This reverts commit 006a589. Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix test typol * ci: remove code scanning workflow (#4569) * fix: Can not add properties in "SetProperties" action (#4572) * bug fix * pr comment * pr comments Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> * update url * Revert "Test skill (#2)" This reverts commit c401768. * fix conflict * fix e2e test * fix unit test * update the diagnostic page * update the warning iconm * fix lint * add some unit tests * fix conflict and update the navigation * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls form dialog dedicated delete api when dialog is removed
Task Item
#minor
#4505