fix: Adds validation for form dialogs propery name #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
added
Team: Authoring
Area: Form Dialogs
hatpick
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
srinaath and
tonyanziano
as code owners
| @@ -2,3 +2,5 @@ | |||
| // Licensed under the MIT License. | |||
|
|
|||
| export const jsPropertyListClassName = 'jsPropertyListClassName'; | |||
|
|
|||
| export const nameRegex = /^[a-zA-Z0-9-_]+$/; | |||
There was a problem hiding this comment.
I see this in the SDK schema for AgeEntityRecognizer. I wonder if the sdk schema should define a pattern for a valid property name rather than string? Or maybe this is too meta for a JSON schema.
"$kind": {
"title": "Kind of dialog object",
"description": "Defines the valid properties for the component you are configuring (from a dialog .schema file)",
"type": "string",
"pattern": "^[a-zA-Z][a-zA-Z0-9.]*$",
"const": "Microsoft.ActivityTemplate"
},
GeoffCoxMSFT
approved these changes
Oct 29, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 5, 2020
* settingsPage: (110 commits) code style update qna end point key after update qna subscription key handle comments handle comments chore: remove orchestrator (microsoft#4602) feat: taking control recognizer generation enhancements (microsoft#4549) chore: Set up Nightly static analysis pipeline in ADO (microsoft#4589) feature: show multi-skill project with correct link behavior (microsoft#4466) doc: guidelines/help-contents (microsoft#4354) Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations (microsoft#4570) feat: Disable Connect to Skill menu action inside skill (microsoft#4557) fix (microsoft#4591) fix: Adds validation for form dialogs propery name (microsoft#4574) fix: update archive version in extensions/vacore (microsoft#4571) fix: e2e test (microsoft#4581) perf: avoid redraw when Project Tree selected item not changed (microsoft#4564) fix: security analysis failure due to bl package version (microsoft#4580) fix publish ut timeout (microsoft#4578) fix: Can not add properties in "SetProperties" action (microsoft#4572) ci: remove code scanning workflow (microsoft#4569) ...
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Adds validation for form dialogs propery name * fix start over name * updatd strings Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per Melanie's request, this PR adds property name validation to the form dialog property names.
Task Item
#minor
