Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bundle extensions #4745

Merged
merged 2 commits into from
Nov 10, 2020
Merged

chore: bundle extensions #4745

merged 2 commits into from
Nov 10, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Use webpack to bundle node extensions to reduce overall app bundle size.

Task Item

#minor

update extensions to bundle code

make webpack output a commonjs module

skip node modules when copying

actually exclude node_modules and hostedBots

no need to clean dev dependencies

fix up remaining extensions
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@a-b-r-o-w-n a-b-r-o-w-n merged commit b2bbf3f into main Nov 10, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/bundle-extensions branch November 10, 2020 16:50
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.292% when pulling b513407 on abrown/bundle-extensions into 7bb1f5a on main.

alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 12, 2020
* settingsPage:
  remove useless files
  Corrected types
  Support undo/redo for skill (microsoft#4754)
  fix UT
  feat: Diagnostics Page (microsoft#4457)
  set defaultLanguage as active language if active language is deleted
  fix: correct URL when switching page modes (microsoft#4736)
  fix: do not stub __dirname for node extensions (microsoft#4749)
  chore: bundle extensions (microsoft#4745)
  fix: Delete & Undo on actions with LG templates doesn't bring back the LG content (microsoft#4740)
  feat: update sdk package to 4.11.0 (microsoft#4741)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* bundle extensions

update extensions to bundle code

make webpack output a commonjs module

skip node modules when copying

actually exclude node_modules and hostedBots

no need to clean dev dependencies

fix up remaining extensions

* revert vscode settings change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants