Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update debounced update handlers #4790

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix: update debounced update handlers #4790

merged 3 commits into from
Nov 12, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Nov 12, 2020

Description

Updates the lg and lu update handlers to be invoked on the leading AND trailing edges of the debounce period, fixing a serialization issue.

Task Item

#minor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.732% when pulling e5b3503 on abrown/lg-perf into 053b724 on main.

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as draft November 12, 2020 18:48
@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review November 12, 2020 23:47
@a-b-r-o-w-n a-b-r-o-w-n merged commit 67d0851 into main Nov 12, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/lg-perf branch November 12, 2020 23:48
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 18, 2020
* feature/bot-projects:
  fix: keep highlight on item with the menu open (microsoft#4835)
  All tests passed
  chore: Pull form dialogs feature branch back to main (microsoft#4841)
  X-platform fix for electron-server "start" script (microsoft#4833)
  build: add option to force rebuild of extensions (microsoft#4830)
  fix: remove checkURL call from navTo on dialog clicks (microsoft#4795)
  fix: export to zip (microsoft#4820)
  fix: prevent minification of AbortSignal (microsoft#4829)
  feat: Settings page (microsoft#4456)
  feat: bot projects skill & context menu (microsoft#4492)
  fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807)
  Removed some extraneous characters from the downloaded pva zip name (microsoft#4808)
  fix: Fixes linux icons on the taskbar (microsoft#4806)
  Update 1.2.0.md
  release: 1.2.0 (microsoft#4796)
  fix: validate bot name when passed via URL params (microsoft#4712)
  fix async move (microsoft#4799)
  fix: Await until delete action finishes (microsoft#4792)
  fix: update debounced update handlers (microsoft#4790)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants