a11y: improve tree filtering keyboard navigation and announcement #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following issues: - Unable to go through filtered tree items via keyboard as the filter immediately gets closed after a blur event - Narrator doesn't announce search results and related instructions for filter The former issue is fixed by preserving the search query in case the query is not empty. If the query is empty blur causes the filter to close. I'd like to note that the filtered state is preserved until a user explicitly clears the search query. To me, this should be the desired behavior. The later issue has more to note about: - Refactored announcement to use `Announced` component from FluentUI built-ins. - Since Narrator still has issues with announcing status/alert roles used by the Announced component, added an explicit `aria-labeledby` link to the announced text, so it can be announced using Narrator shortcuts while navigating through the searchbox or the tree itself. - Improved announcement message to include the region label and more information regarding the current search query the result is provided for.
OEvgeny
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford,
tonyanziano and
VamsiModem
as code owners
OEvgeny
changed the title
tonyanziano
approved these changes
Feb 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the following issues:
The former issue is fixed by preserving the search query in case the query is not empty. If the query is empty blur causes the filter to close. I'd like to note that the filtered state is preserved until a user explicitly clears the search query. To me, this should be the desired behavior.
The later issue has more to note about:
Announcedcomponent from FluentUI built-ins. Tested with NVDA and it works.aria-labeledbylink to the announced text, so it can be announced using Narrator shortcuts while navigating through the searchbox or the tree itself.Task Item
Screenshots
#minor