fix: version hash display in development builds #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
changed the title
OEvgeny
requested review from
cwhitten,
boydc2014,
a-b-r-o-w-n,
srinaath,
benbrown,
tdurnford,
natalgar and
VamsiModem
as code owners
OEvgeny
changed the title
tdurnford
approved these changes
Sep 20, 2022
cwhitten
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current revision is missing in development environment. The command provided gives the following error on my machine:
In addition the output is null when
stdiois set to"ignore".Accessibility testers now use Composer built from sources for testing on the web. This fix will help them reporting current revision correctly.
Screenshots
#minor