fix: [#9346] Fix memory leak issues in VisualPanel components #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested review from
benbrown,
VamsiModem,
cwhitten,
boydc2014,
a-b-r-o-w-n,
srinaath and
tdurnford
as code owners
anishprasad01
added
the
Support-P0
tracyboehrer
previously approved these changes
Jan 19, 2023
tracyboehrer
removed request for
benbrown,
cwhitten,
a-b-r-o-w-n,
boydc2014,
VamsiModem,
srinaath and
tdurnford
tracyboehrer
approved these changes
Jan 20, 2023
OEvgeny
reviewed
Jan 20, 2023
Composer/packages/adaptive-flow/src/adaptive-flow-editor/AdaptiveFlowEditor.tsx
Show resolved
Hide resolved
OEvgeny
approved these changes
Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR applies minor fixes in some of the VisualPanel components to avoid detached elements in memory.
Every time we open the design page in Composer, a detached element is added to the memory and it can't be removed by the garbage collector. If we switch between pages for a while, the memory usage increases and it may end up causing an out-of-memory exception.
Task Item
Addresses #9346
Screenshots
These images show the detached elements being removed by the garbage collector after the fixes.
